jan-henrik/constellation-analyzer
1
0
Fork 0
mirror of https://github.com/OFFIS-ESC/constellation-analyzer synced 2026-01-26 23:43:40 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
constellation-analyzer/docs
History
Jan-Henrik Bruhn 3f24e4be0b fix: correct history timing in createGroupWithActors for proper undo behavior 
Fixes incorrect undo behavior when creating groups with actors.

Previously, history was captured AFTER mutations, causing undo to restore
a state that included the group. This fix moves history capture to BEFORE
mutations, making it consistent with all other operations (addNode,
deleteNode, addEdge, etc.).

Changes:
- Move pushToHistory() call before mutations in createGroupWithActors
- Add detailed comment explaining the timing
- Update refactoring plan with implementation status

Impact:
- Undo now correctly removes groups and ungroups actors
- Behavior consistent with all other operations
- No breaking changes to existing functionality

Testing:
- TypeScript compilation verified (npx tsc --noEmit)
- Manual testing plan documented in PHASE_4_1_TEST_PLAN.md
- 6 test cases defined for comprehensive verification

Related: Phase 4.1 of STATE_MANAGEMENT_REFACTORING_PLAN.md

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-10-20 12:09:09 +02:00
..
DIRECTIONAL_RELATIONSHIPS_UX_SPEC.md feat: add document naming dialog before creation 2025-10-11 12:03:05 +02:00
IMPLEMENTATION_CHECKLIST.md doc: move some plans around 2025-10-11 22:08:53 +02:00
KEYBOARD_SHORTCUTS.md Initial commit 2025-10-10 11:15:51 +02:00
MULTI_FILE_PLAN.md Initial commit 2025-10-10 11:15:51 +02:00
PERSISTENCE_PLAN.md Initial commit 2025-10-10 11:15:51 +02:00
PHASE_4_1_TEST_PLAN.md fix: correct history timing in createGroupWithActors for proper undo behavior 2025-10-20 12:09:09 +02:00
PROJECT_SUMMARY.md Initial commit 2025-10-10 11:15:51 +02:00
SIDE_PANELS_UX_DESIGN.md feat: side panels for properties and tools 2025-10-10 18:13:18 +02:00
STATE_MANAGEMENT_REFACTORING_PLAN.md fix: correct history timing in createGroupWithActors for proper undo behavior 2025-10-20 12:09:09 +02:00
TEMPORAL_ANALYSIS_SUMMARY.md doc: move some plans around 2025-10-11 22:08:53 +02:00
TEMPORAL_QUICK_START.md doc: move some plans around 2025-10-11 22:08:53 +02:00
TEMPORAL_SCENARIO_IMPLEMENTATION_PLAN.md doc: move some plans around 2025-10-11 22:08:53 +02:00
TEMPORAL_SCENARIO_UX_CONCEPT.md doc: move some plans around 2025-10-11 22:08:53 +02:00
UNDO_REDO_IMPLEMENTATION.md refactor: migrate undo/redo from per-state to per-document level 2025-10-11 22:38:23 +02:00
UX_ANALYSIS.md Initial commit 2025-10-10 11:15:51 +02:00
UX_ANALYSIS_ACTOR_TYPE_SETTINGS.md feat: redesign relation type configuration with improved UX 2025-10-16 19:47:12 +02:00
UX_CONCEPT_MULTI_VERSION_GRAPH.md doc: move some plans around 2025-10-11 22:08:53 +02:00
VISUAL_EXAMPLES.md doc: move some plans around 2025-10-11 22:08:53 +02:00
WORKSPACE_PERSISTENCE.md Initial commit 2025-10-10 11:15:51 +02:00