jan-henrik/eurorack
1
0
Fork 0
mirror of https://github.com/jhbruhn/eurorack.git synced 2025-10-30 02:46:01 +00:00
Code Issues Projects Releases Packages Wiki Activity

Remove unused visible parameter from menu items, select part 0 as default on boot

Browse source
This commit is contained in:
Jan-Henrik 2020-02-23 01:15:49 +01:00
parent cda0831b9d
commit 0fd1657c60
3 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
midi2cv/menu/menu_items.h
View file

@ -16,7 +16,6 @@ template <class T>
class MenuItem : public AbstractMenuItem { class MenuItem : public AbstractMenuItem {
private: private:
const char* label; const char* label;
bool visible;
T value; T value;
T step; T step;
char stringRepresentation[24]; char stringRepresentation[24];
@ -24,7 +23,6 @@ class MenuItem : public AbstractMenuItem {
protected: protected:
MenuItem(const char* _label, T _initialValue) MenuItem(const char* _label, T _initialValue)
: label(_label) : label(_label)
, visible(true)
, value(_initialValue) {}; , value(_initialValue) {};
virtual void to_string(char* buf) = 0; virtual void to_string(char* buf) = 0;

2
midi2cv/ui/main_menu.h
View file

@ -14,7 +14,7 @@ class MainMenu {
void render(u8g2_t* u8g2, int x, int y, int width, int height); void render(u8g2_t* u8g2, int x, int y, int width, int height);
MainMenu() MainMenu()
: activePartMenu(-1) : activePartMenu(0)
, selectedPart(0) {}; , selectedPart(0) {};
private: private:

3
midi2cv/ui/part_menu.cc
View file

@ -6,7 +6,7 @@
PartMenu::PartMenu() PartMenu::PartMenu()
: item_voice_count("voice count", 1, 1, 4, 1) : item_voice_count("voice count", 1, 1, 4, 1)
, item_voice_detail("voice detail", 1, 1, 4, 1) , item_voice_detail("voice detail", 1, 1, 4, 1)
, item_midi_filter_enabled("MIDI filter", 0, "on", "off") , item_midi_filter_enabled("MIDI filter", 1, "on", "off")
, item_midi_channel("MIDI channel", 0, 0, 100, 1) , item_midi_channel("MIDI channel", 0, 0, 100, 1)
, item_midi_lowest_note("MIDI lowest", 0) , item_midi_lowest_note("MIDI lowest", 0)
, item_midi_highest_note("MIDI highest", 127) , item_midi_highest_note("MIDI highest", 127)
@ -39,6 +39,7 @@ bool PartMenu::back()
bool PartMenu::enter() bool PartMenu::enter()
{ {
menu.enter(); menu.enter();
return false; return false;
} }