jan-henrik/respira
1
0
Fork 0
mirror of https://github.com/jhbruhn/respira.git synced 2026-01-27 10:23:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: Resolve linter issues in pattern converter and hooks

Browse source 
- Change let to const for variables that are never reassigned
- Fix React Hook dependency array warnings in useBrotherMachine
- Remove unused refreshPatternInfo dependency from uploadPattern
- Add missing refreshPatternInfo dependency to startMaskTrace

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This commit is contained in:
Jan-Henrik 2025-12-13 23:30:56 +01:00
parent 8a32d5184e
commit eb774dcb30
3 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/hooks/useBrotherMachine.ts
View file

@ -280,7 +280,7 @@ export function useBrotherMachine() {
setIsUploading(false); // Clear loading state setIsUploading(false); // Clear loading state
} }
}, },
[service, storageService, isConnected, refreshStatus, refreshPatternInfo], [service, storageService, isConnected, refreshStatus],
); );
const startMaskTrace = useCallback(async () => { const startMaskTrace = useCallback(async () => {

4
src/utils/penParser.ts
View file

@ -45,8 +45,8 @@ export function parsePenData(data: Uint8Array): PenData {
if (ySigned > 0x7FFF) ySigned = ySigned - 0x10000; if (ySigned > 0x7FFF) ySigned = ySigned - 0x10000;
// Step 3: Shift right by 3 (arithmetic shift, preserves sign) // Step 3: Shift right by 3 (arithmetic shift, preserves sign)
let x = xSigned >> 3; const x = xSigned >> 3;
let y = ySigned >> 3; const y = ySigned >> 3;
const stitch: PenStitch = { const stitch: PenStitch = {
x, x,

10
src/workers/patternConverter.worker.ts
View file

@ -485,7 +485,7 @@ for i, stitch in enumerate(pattern.stitches):
penStitches.push(...generateLockStitches(prevX, prevY, finishDir.dirX, finishDir.dirY)); penStitches.push(...generateLockStitches(prevX, prevY, finishDir.dirX, finishDir.dirY));
// Encode jump with both FEED and CUT flags // Encode jump with both FEED and CUT flags
let xEncoded = (absX << 3) & 0xffff; const xEncoded = (absX << 3) & 0xffff;
let yEncoded = (absY << 3) & 0xffff; let yEncoded = (absY << 3) & 0xffff;
yEncoded |= PEN_FEED_DATA; // Jump flag yEncoded |= PEN_FEED_DATA; // Jump flag
yEncoded |= PEN_CUT_DATA; // Cut flag for long jumps yEncoded |= PEN_CUT_DATA; // Cut flag for long jumps
@ -579,8 +579,8 @@ for i, stitch in enumerate(pattern.stitches):
// Step 3: If next stitch is a JUMP, encode it and skip it in the loop // Step 3: If next stitch is a JUMP, encode it and skip it in the loop
// Otherwise, add a jump ourselves if positions differ // Otherwise, add a jump ourselves if positions differ
let jumpToX = nextStitchX; const jumpToX = nextStitchX;
let jumpToY = nextStitchY; const jumpToY = nextStitchY;
if (nextIsJump) { if (nextIsJump) {
// The PES has a JUMP to the new color position, we'll add it here and skip it later // The PES has a JUMP to the new color position, we'll add it here and skip it later
@ -596,7 +596,7 @@ for i, stitch in enumerate(pattern.stitches):
// Add jump to new position (if position changed) // Add jump to new position (if position changed)
if (jumpToX !== absX || jumpToY !== absY) { if (jumpToX !== absX || jumpToY !== absY) {
let jumpXEncoded = (jumpToX << 3) & 0xffff; const jumpXEncoded = (jumpToX << 3) & 0xffff;
let jumpYEncoded = (jumpToY << 3) & 0xffff; let jumpYEncoded = (jumpToY << 3) & 0xffff;
jumpYEncoded |= PEN_FEED_DATA; // Jump flag jumpYEncoded |= PEN_FEED_DATA; // Jump flag
@ -612,7 +612,7 @@ for i, stitch in enumerate(pattern.stitches):
// Step 4: Add COLOR_END marker at NEW position // Step 4: Add COLOR_END marker at NEW position
// This is where the machine pauses and waits for the user to change thread color // This is where the machine pauses and waits for the user to change thread color
let colorEndXEncoded = (jumpToX << 3) & 0xffff; let colorEndXEncoded = (jumpToX << 3) & 0xffff;
let colorEndYEncoded = (jumpToY << 3) & 0xffff; const colorEndYEncoded = (jumpToY << 3) & 0xffff;
// Add COLOR_END flag to X coordinate // Add COLOR_END flag to X coordinate
colorEndXEncoded = (colorEndXEncoded & 0xfff8) | PEN_COLOR_END; colorEndXEncoded = (colorEndXEncoded & 0xfff8) | PEN_COLOR_END;