jan-henrik/respira

Fork 0

mirror of https://github.com/jhbruhn/respira.git synced 2026-01-27 10:23:41 +00:00

Commit graph

Author	SHA1	Message	Date
Jan-Henrik Bruhn	e1aadc9e1f	feature: Create comprehensive custom hooks library (WIP) - Extract 5 new custom hooks: * useAutoScroll - Auto-scroll element into view * useClickOutside - Detect outside clicks with exclusions * useMachinePolling - Dynamic machine status polling * useErrorPopoverState - Error popover state management * useBluetoothDeviceListener - Bluetooth device discovery - Reorganize all hooks into categorized folders: * utility/ - Generic reusable patterns * domain/ - Business logic for embroidery/patterns * ui/ - Library integration (Konva) * platform/ - Electron/Pyodide specific - Create barrel exports for clean imports (@/hooks) - Update components to use new hooks: * AppHeader uses useErrorPopoverState * ProgressMonitor uses useAutoScroll * FileUpload, PatternCanvas use barrel exports Part 1: Hooks extraction and reorganization Still TODO: Update remaining components, add tests, add documentation Related to #40 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>	2025-12-27 12:19:12 +01:00
Jan-Henrik Bruhn	e63a96b024	fix: Address PR review comments - Remove redundant useMemo wrapper in usePatternValidation Inline the calculation logic directly in useMemo instead of useCallback + useMemo pattern for better clarity and efficiency - Remove unnecessary 'Early return' comment in usePatternRotationUpload The return statement is self-explanatory	2025-12-27 11:39:48 +01:00
Jan-Henrik Bruhn	c905c4f5f7	refactor: Extract business logic from FileUpload into custom hooks Problem: FileUpload component mixed UI and business logic making it: - Hard to test business logic independently - Difficult to reuse logic elsewhere - Component had too many responsibilities (550+ lines) - Harder to understand and maintain Solution: Extracted business logic into three focused custom hooks: 1. useFileUpload (84 lines) - File selection and conversion - Pyodide initialization handling - Error handling 2. usePatternRotationUpload (145 lines) - Rotation transformation logic - PEN encoding/decoding - Center shift calculation - Upload orchestration 3. usePatternValidation (105 lines) - Bounds checking logic - Rotated pattern validation - Error message generation Impact: - FileUpload component reduced from 550 → 350 lines (36% smaller) - Business logic now testable in isolation - Clear separation of concerns - Logic can be reused in other components - Improved maintainability Technical Details: - All hooks fully typed with TypeScript - Proper dependency management with useCallback/useMemo - No behavioral changes - Build tested successfully - Linter passed Fixes #39 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>	2025-12-27 11:36:04 +01:00

Author

SHA1

Message

Date

Jan-Henrik Bruhn

e1aadc9e1f

feature: Create comprehensive custom hooks library (WIP)

- Extract 5 new custom hooks:
  * useAutoScroll - Auto-scroll element into view
  * useClickOutside - Detect outside clicks with exclusions
  * useMachinePolling - Dynamic machine status polling
  * useErrorPopoverState - Error popover state management
  * useBluetoothDeviceListener - Bluetooth device discovery

- Reorganize all hooks into categorized folders:
  * utility/ - Generic reusable patterns
  * domain/ - Business logic for embroidery/patterns
  * ui/ - Library integration (Konva)
  * platform/ - Electron/Pyodide specific

- Create barrel exports for clean imports (@/hooks)

- Update components to use new hooks:
  * AppHeader uses useErrorPopoverState
  * ProgressMonitor uses useAutoScroll
  * FileUpload, PatternCanvas use barrel exports

Part 1: Hooks extraction and reorganization
Still TODO: Update remaining components, add tests, add documentation

Related to #40

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

2025-12-27 12:19:12 +01:00

Jan-Henrik Bruhn

e63a96b024

fix: Address PR review comments

- Remove redundant useMemo wrapper in usePatternValidation
  Inline the calculation logic directly in useMemo instead of
  useCallback + useMemo pattern for better clarity and efficiency

- Remove unnecessary 'Early return' comment in usePatternRotationUpload
  The return statement is self-explanatory

2025-12-27 11:39:48 +01:00

Jan-Henrik Bruhn

c905c4f5f7

refactor: Extract business logic from FileUpload into custom hooks

**Problem:**
FileUpload component mixed UI and business logic making it:
- Hard to test business logic independently
- Difficult to reuse logic elsewhere
- Component had too many responsibilities (550+ lines)
- Harder to understand and maintain

**Solution:**
Extracted business logic into three focused custom hooks:

1. **useFileUpload** (84 lines)
   - File selection and conversion
   - Pyodide initialization handling
   - Error handling

2. **usePatternRotationUpload** (145 lines)
   - Rotation transformation logic
   - PEN encoding/decoding
   - Center shift calculation
   - Upload orchestration

3. **usePatternValidation** (105 lines)
   - Bounds checking logic
   - Rotated pattern validation
   - Error message generation

**Impact:**
- FileUpload component reduced from 550 → 350 lines (36% smaller)
- Business logic now testable in isolation
- Clear separation of concerns
- Logic can be reused in other components
- Improved maintainability

**Technical Details:**
- All hooks fully typed with TypeScript
- Proper dependency management with useCallback/useMemo
- No behavioral changes
- Build tested successfully
- Linter passed

Fixes #39

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

2025-12-27 11:36:04 +01:00

3 commits